-
Notifications
You must be signed in to change notification settings - Fork 71
chore(code): remove deprecated prop warnings and storybook references #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4fd7e70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes deprecated prop warning logic and Storybook references from the @leafygreen-ui/code component. The deprecated props (copyable, showCustomActionButtons, languageOptions, customActionButtons, chromeTitle, onChange) were already removed in v18, and this cleanup removes the remaining runtime warning code and Storybook control references.
Key changes:
- Removes deprecated prop warning checks from the Code component
- Removes deprecated prop references from Storybook configuration
- Adds changeset documenting the cleanup
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/code/src/Code/Code.tsx | Removes deprecated prop warning logic that checked for props removed in v18 |
| packages/code/src/Code.stories.tsx | Removes copyable control references from Storybook configuration |
| .changeset/nasty-planets-tap.md | Documents the removal of deprecated prop mentions as a patch change |
|
Size Change: -291 B (-0.02%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
✍️ Proposed changes
This PR cleans up the
@leafygreen-ui/codecomponent by removing deprecated prop warning checks and Storybook references. These props (copyable, showCustomActionButtons, languageOptions, customActionButtons, chromeTitle, onChange) were already removed in v18, and this change removes the runtime warning code and any remaining references in Storybook configuration.🎟️ Jira ticket: N/A
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
copyablecontrol no longer appears in the Storybook controls panel